Skip to content

3845 add status check#3846

Merged
wyli merged 1 commit into
Project-MONAI:devfrom
yiheng-wang-nv:3845-add-status-check
Feb 23, 2022
Merged

3845 add status check#3846
wyli merged 1 commit into
Project-MONAI:devfrom
yiheng-wang-nv:3845-add-status-check

Conversation

@yiheng-wang-nv

@yiheng-wang-nv yiheng-wang-nv commented Feb 23, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Yiheng Wang vennw@nvidia.com

Fixes #3845 .

Description

A few sentences describing the changes proposed in this pull request.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv changed the title [draft] 3845 add status check [WIP] 3845 add status check Feb 23, 2022
@yiheng-wang-nv yiheng-wang-nv changed the title [WIP] 3845 add status check 3845 add status check Feb 23, 2022

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli

wyli commented Feb 23, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli wyli merged commit d6327a7 into Project-MONAI:dev Feb 23, 2022
wyli pushed a commit to wyli/MONAI that referenced this pull request Feb 24, 2022
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli pushed a commit to wyli/MONAI that referenced this pull request Feb 24, 2022
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_get_all_ngc_models uses requests.get and need to check the returned data

2 participants